[Refactor] Replace enum-driven modifier system with data-driven SO composition

Replace the entire static, enum-based modifier pipeline with a
composition-based, data-driven architecture using ScriptableObject
polymorphism. New modifiers can now be created by assembling SO building
blocks (Conditions + Effects + Behaviors) — no core code edits needed.

New architecture:
- Core/: TriggerType, ModifierPhase, ModifierContext, ICondition, IEffect
- Definition/: ModifierDefinitionSO, ModifierBehaviorSO, ConditionSO, EffectSO, ModifierCatalogSO
- Conditions/: DieValueCondition, CategoryCondition, MinScoreCondition, DiceCountCondition
- Effects/: AddFlat, AddPerDie, Multiply, MultiplyPerDie, PostMultiply, AddCurrency, ConsumeCharge
- Runtime/: ModifierInstance, ModifierRegistry (non-static service)
- Pipeline/: async ModifierPipeline with phase ordering, tracing, anti-recursion
- Editor/: ModifierDefinitionValidator with menu items
- Events/: GameEventBus (non-static typed dispatcher)
- DI/: GameLifetimeScope (VContainer composition root)

Deleted old system: ModifierData, ModifierEffect, ModifierEnums,
ModifierPipeline (static), ModifierRuntime, ModifierTarget, ShopCatalog,
ModifierAssetCreator.

Updated: ScoringSystem (VContainer + async), InventoryModel (delegates to
ModifierRegistry), ShopModel (uses ModifierDefinitionSO), GameController
(VContainer injection), SaveData (uses Runtime.ModifierSaveEntry), all
views/controllers, and all test files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Assets/Scripts/DI/GameLifetimeScope.cs

@@ -0,0 +1,41 @@
+using UnityEngine;
+using VContainer;
+using VContainer.Unity;
+using YachtDice.Economy;
+using YachtDice.Events;
+using YachtDice.Game;
+using YachtDice.Modifiers.Definition;
+using YachtDice.Modifiers.Pipeline;
+using YachtDice.Modifiers.Runtime;
+using YachtDice.Scoring;
+
+namespace YachtDice.DI
+{
+    public class GameLifetimeScope : LifetimeScope
+    {
+        [SerializeField] private ModifierCatalogSO modifierCatalog;
+
+        [Header("Scene References")]
+        [SerializeField] private ScoringSystem scoringSystem;
+        [SerializeField] private CurrencyBank currencyBank;
+        [SerializeField] private GameManager gameManager;
+        [SerializeField] private DiceManager diceManager;
+
+        protected override void Configure(IContainerBuilder builder)
+        {
+            // SO catalog
+            builder.RegisterInstance(modifierCatalog);
+
+            // Core modifier services
+            builder.Register<ModifierRegistry>(Lifetime.Singleton);
+            builder.Register<ModifierPipeline>(Lifetime.Singleton);
+            builder.Register<GameEventBus>(Lifetime.Singleton);
+
+            // Scene MonoBehaviour components
+            builder.RegisterComponent(scoringSystem);
+            builder.RegisterComponent(currencyBank);
+            builder.RegisterComponent(gameManager);
+            builder.RegisterComponent(diceManager);
+        }
+    }
+}