[Refactor] Replace enum-driven modifier system with data-driven SO composition

Replace the entire static, enum-based modifier pipeline with a composition-based, data-driven architecture using ScriptableObject polymorphism. New modifiers can now be created by assembling SO building blocks (Conditions + Effects + Behaviors) — no core code edits needed. New architecture: - Core/: TriggerType, ModifierPhase, ModifierContext, ICondition, IEffect - Definition/: ModifierDefinitionSO, ModifierBehaviorSO, ConditionSO, EffectSO, ModifierCatalogSO - Conditions/: DieValueCondition, CategoryCondition, MinScoreCondition, DiceCountCondition - Effects/: AddFlat, AddPerDie, Multiply, MultiplyPerDie, PostMultiply, AddCurrency, ConsumeCharge - Runtime/: ModifierInstance, ModifierRegistry (non-static service) - Pipeline/: async ModifierPipeline with phase ordering, tracing, anti-recursion - Editor/: ModifierDefinitionValidator with menu items - Events/: GameEventBus (non-static typed dispatcher) - DI/: GameLifetimeScope (VContainer composition root) Deleted old system: ModifierData, ModifierEffect, ModifierEnums, ModifierPipeline (static), ModifierRuntime, ModifierTarget, ShopCatalog, ModifierAssetCreator. Updated: ScoringSystem (VContainer + async), InventoryModel (delegates to ModifierRegistry), ShopModel (uses ModifierDefinitionSO), GameController (VContainer injection), SaveData (uses Runtime.ModifierSaveEntry), all views/controllers, and all test files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-01 06:20:23 +07:00
parent 6e19de2f3d
commit 68c4abace3
57 changed files with 2227 additions and 912 deletions
@@ -0,0 +1,43 @@
+using System.Collections.Generic;
+using UnityEngine;
+using YachtDice.Modifiers.Core;
+using YachtDice.Modifiers.Runtime;
+
+namespace YachtDice.Modifiers.Definition
+{
+    [CreateAssetMenu(fileName = "NewBehavior", menuName = "YachtDice/Modifiers/Behavior")]
+    public class ModifierBehaviorSO : ScriptableObject
+    {
+        [SerializeField] private TriggerType trigger;
+        [SerializeField] private List<ConditionSO> conditions = new();
+        [SerializeField] private List<EffectSO> effects = new();
+
+        public TriggerType Trigger => trigger;
+        public IReadOnlyList<ConditionSO> Conditions => conditions;
+        public IReadOnlyList<EffectSO> Effects => effects;
+
+        public bool EvaluateConditions(ModifierContext context, ModifierInstance instance)
+        {
+            for (int i = 0; i < conditions.Count; i++)
+            {
+                if (conditions[i] != null && !conditions[i].Evaluate(context, instance))
+                    return false;
+            }
+            return true;
+        }
+
+#if UNITY_EDITOR
+        public static ModifierBehaviorSO CreateForTest(
+            TriggerType trigger,
+            List<ConditionSO> conditions,
+            List<EffectSO> effects)
+        {
+            var so = CreateInstance<ModifierBehaviorSO>();
+            so.trigger = trigger;
+            so.conditions = conditions ?? new List<ConditionSO>();
+            so.effects = effects ?? new List<EffectSO>();
+            return so;
+        }
+#endif
+    }
+}