[Refactor] Replace enum-driven modifier system with data-driven SO composition

Replace the entire static, enum-based modifier pipeline with a composition-based, data-driven architecture using ScriptableObject polymorphism. New modifiers can now be created by assembling SO building blocks (Conditions + Effects + Behaviors) — no core code edits needed. New architecture: - Core/: TriggerType, ModifierPhase, ModifierContext, ICondition, IEffect - Definition/: ModifierDefinitionSO, ModifierBehaviorSO, ConditionSO, EffectSO, ModifierCatalogSO - Conditions/: DieValueCondition, CategoryCondition, MinScoreCondition, DiceCountCondition - Effects/: AddFlat, AddPerDie, Multiply, MultiplyPerDie, PostMultiply, AddCurrency, ConsumeCharge - Runtime/: ModifierInstance, ModifierRegistry (non-static service) - Pipeline/: async ModifierPipeline with phase ordering, tracing, anti-recursion - Editor/: ModifierDefinitionValidator with menu items - Events/: GameEventBus (non-static typed dispatcher) - DI/: GameLifetimeScope (VContainer composition root) Deleted old system: ModifierData, ModifierEffect, ModifierEnums, ModifierPipeline (static), ModifierRuntime, ModifierTarget, ShopCatalog, ModifierAssetCreator. Updated: ScoringSystem (VContainer + async), InventoryModel (delegates to ModifierRegistry), ShopModel (uses ModifierDefinitionSO), GameController (VContainer injection), SaveData (uses Runtime.ModifierSaveEntry), all views/controllers, and all test files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-01 06:20:23 +07:00
parent 6e19de2f3d
commit 68c4abace3
57 changed files with 2227 additions and 912 deletions
@@ -0,0 +1,29 @@
+using System.Collections.Generic;
+using YachtDice.Modifiers.Definition;
+
+namespace YachtDice.Modifiers.Runtime
+{
+    public class ModifierInstance
+    {
+        public ModifierDefinitionSO Definition { get; }
+        public bool IsActive { get; set; }
+        public int RemainingUses { get; set; }
+        public int Stacks { get; set; } = 1;
+        public Dictionary<string, float> CustomState { get; } = new();
+
+        public bool IsExpired => Definition.HasLimitedUses && RemainingUses <= 0;
+
+        public ModifierInstance(ModifierDefinitionSO definition)
+        {
+            Definition = definition;
+            RemainingUses = definition.HasLimitedUses ? definition.MaxUses : -1;
+        }
+
+        public void ConsumeCharge(int amount = 1)
+        {
+            if (!Definition.HasLimitedUses) return;
+            RemainingUses -= amount;
+            if (RemainingUses < 0) RemainingUses = 0;
+        }
+    }
+}