diff --git a/Assets/Scripts/Dice/DiceCatalog.cs b/Assets/Scripts/Dice/DiceCatalog.cs index c72ffef..f03f8b3 100644 --- a/Assets/Scripts/Dice/DiceCatalog.cs +++ b/Assets/Scripts/Dice/DiceCatalog.cs @@ -6,11 +6,11 @@ namespace YachtDice.Dice [CreateAssetMenu(fileName = "DiceCatalog", menuName = "YachtDice/Dice/Catalog")] public class DiceCatalog : ScriptableObject { - [SerializeField] private List dice = new(); + [SerializeField] private List dice = new(); - public IReadOnlyList All => dice; + public IReadOnlyList All => dice; - public DiceDefinitionSO FindById(string id) + public DiceDefinition FindById(string id) { for (int i = 0; i < dice.Count; i++) { @@ -21,10 +21,10 @@ namespace YachtDice.Dice } #if UNITY_EDITOR - public static DiceCatalog CreateForTest(List defs) + public static DiceCatalog CreateForTest(List defs) { var catalog = CreateInstance(); - catalog.dice = defs ?? new List(); + catalog.dice = defs ?? new List(); return catalog; } #endif diff --git a/Assets/Scripts/Dice/DiceDefinitionSO.cs b/Assets/Scripts/Dice/DiceDefinition.cs similarity index 74% rename from Assets/Scripts/Dice/DiceDefinitionSO.cs rename to Assets/Scripts/Dice/DiceDefinition.cs index df49f3a..1807b0b 100644 --- a/Assets/Scripts/Dice/DiceDefinitionSO.cs +++ b/Assets/Scripts/Dice/DiceDefinition.cs @@ -7,11 +7,7 @@ namespace YachtDice.Dice /// Абстрактное определение типа дайса. /// Наследники описывают конкретные виды (стандартный d6, специальные и т.д.). /// -<<<<<<<< HEAD:Assets/Scripts/Dice/DiсeDefinition.cs - public abstract class DiсeDefinition : ScriptableObject, IShopItem -======== - public abstract class DiceDefinitionSO : ScriptableObject, IShopItem ->>>>>>>> claude/vibrant-tereshkova:Assets/Scripts/Dice/DiceDefinitionSO.cs + public abstract class DiceDefinition : ScriptableObject, IShopItem { [field: Header("Identity")] [field: SerializeField] public string Id { get; private set; } @@ -32,11 +28,7 @@ namespace YachtDice.Dice #if UNITY_EDITOR public static T CreateForTest(string id, string displayName = null, -<<<<<<<< HEAD:Assets/Scripts/Dice/DiсeDefinition.cs - int shopPrice = 0, string description = null) where T : DiсeDefinition -======== - int shopPrice = 0, string description = null) where T : DiceDefinitionSO ->>>>>>>> claude/vibrant-tereshkova:Assets/Scripts/Dice/DiceDefinitionSO.cs + int shopPrice = 0, string description = null) where T : DiceDefinition { var so = CreateInstance(); so.Id = id; diff --git a/Assets/Scripts/Dice/DiceDefinitionSO.cs.meta b/Assets/Scripts/Dice/DiceDefinition.cs.meta similarity index 100% rename from Assets/Scripts/Dice/DiceDefinitionSO.cs.meta rename to Assets/Scripts/Dice/DiceDefinition.cs.meta diff --git a/Assets/Scripts/Dice/DiceInstance.cs b/Assets/Scripts/Dice/DiceInstance.cs index 53a4d6c..4446c36 100644 --- a/Assets/Scripts/Dice/DiceInstance.cs +++ b/Assets/Scripts/Dice/DiceInstance.cs @@ -6,18 +6,18 @@ namespace YachtDice.Dice /// public class DiceInstance : IDice { - public DiceDefinitionSO Definition { get; } + public DiceDefinition Definition { get; } public int Value { get; set; } public bool IsLocked { get; set; } - public DiceInstance(DiceDefinitionSO definition) + public DiceInstance(DiceDefinition definition) { Definition = definition; Value = 0; IsLocked = false; } - public DiceInstance(DiceDefinitionSO definition, int initialValue) + public DiceInstance(DiceDefinition definition, int initialValue) { Definition = definition; Value = initialValue; diff --git a/Assets/Scripts/Dice/DiceRoller.cs b/Assets/Scripts/Dice/DiceRoller.cs index dd8eab3..6c8eecf 100644 --- a/Assets/Scripts/Dice/DiceRoller.cs +++ b/Assets/Scripts/Dice/DiceRoller.cs @@ -16,7 +16,7 @@ namespace YachtDice.Dice [SerializeField] private Rigidbody rb; /// Определение типа дайса (назначается в инспекторе). - [field: SerializeField] public DiceDefinitionSO Definition { get; private set; } + [field: SerializeField] public DiceDefinition Definition { get; private set; } [Header("Throw Settings")] [Tooltip("Сила подброса вверх")] diff --git a/Assets/Scripts/Dice/IDice.cs b/Assets/Scripts/Dice/IDice.cs index eab00f7..511f92c 100644 --- a/Assets/Scripts/Dice/IDice.cs +++ b/Assets/Scripts/Dice/IDice.cs @@ -10,6 +10,6 @@ namespace YachtDice.Dice int Value { get; } /// Определение типа дайса (ScriptableObject). - DiceDefinitionSO Definition { get; } + DiceDefinition Definition { get; } } } diff --git a/Assets/Scripts/Dice/StandardDiceSO.cs b/Assets/Scripts/Dice/StandardDice.cs similarity index 55% rename from Assets/Scripts/Dice/StandardDiceSO.cs rename to Assets/Scripts/Dice/StandardDice.cs index 53e51c3..82ad313 100644 --- a/Assets/Scripts/Dice/StandardDiceSO.cs +++ b/Assets/Scripts/Dice/StandardDice.cs @@ -7,11 +7,7 @@ namespace YachtDice.Dice /// По умолчанию — классический d6 (1-6). /// [CreateAssetMenu(fileName = "StandardDice", menuName = "YachtDice/Dice/Standard Dice")] -<<<<<<<< HEAD:Assets/Scripts/Dice/StandardDiсe.cs - public class StandardDiсe : DiсeDefinition -======== - public class StandardDiceSO : DiceDefinitionSO ->>>>>>>> claude/vibrant-tereshkova:Assets/Scripts/Dice/StandardDiceSO.cs + public class StandardDice : DiceDefinition { [Header("Configuration")] [SerializeField] private int[] faceValues = { 1, 2, 3, 4, 5, 6 }; @@ -26,15 +22,9 @@ namespace YachtDice.Dice } #if UNITY_EDITOR -<<<<<<<< HEAD:Assets/Scripts/Dice/StandardDiсe.cs - public static StandardDiсe CreateStandardD6ForTest() + public static StandardDice CreateStandardD6ForTest() { - var so = CreateForTest("standard_d6", "Стандартный d6"); -======== - public static StandardDiceSO CreateStandardD6ForTest() - { - var so = CreateForTest("standard_d6", "Стандартный d6"); ->>>>>>>> claude/vibrant-tereshkova:Assets/Scripts/Dice/StandardDiceSO.cs + var so = CreateForTest("standard_d6", "Стандартный d6"); so.faceValues = new[] { 1, 2, 3, 4, 5, 6 }; return so; } diff --git a/Assets/Scripts/Dice/StandardDiceSO.cs.meta b/Assets/Scripts/Dice/StandardDice.cs.meta similarity index 100% rename from Assets/Scripts/Dice/StandardDiceSO.cs.meta rename to Assets/Scripts/Dice/StandardDice.cs.meta diff --git a/Assets/Scripts/Player/DiceCollection.cs b/Assets/Scripts/Player/DiceCollection.cs index 7a4d602..472ac11 100644 --- a/Assets/Scripts/Player/DiceCollection.cs +++ b/Assets/Scripts/Player/DiceCollection.cs @@ -6,13 +6,13 @@ namespace YachtDice.Player { public class DiceCollection { - private readonly List ownedDice = new(); + private readonly List ownedDice = new(); public event Action OnChanged; - public IReadOnlyList OwnedDice => ownedDice; + public IReadOnlyList OwnedDice => ownedDice; - public void Add(DiceDefinitionSO definition) + public void Add(DiceDefinition definition) { if (definition == null) return; if (OwnsById(definition.Id)) return; @@ -21,7 +21,7 @@ namespace YachtDice.Player OnChanged?.Invoke(); } - public void Remove(DiceDefinitionSO definition) + public void Remove(DiceDefinition definition) { if (ownedDice.Remove(definition)) OnChanged?.Invoke(); diff --git a/Assets/Scripts/Shop/ShopModel.cs b/Assets/Scripts/Shop/ShopModel.cs index 16cdfb2..936d771 100644 --- a/Assets/Scripts/Shop/ShopModel.cs +++ b/Assets/Scripts/Shop/ShopModel.cs @@ -49,7 +49,7 @@ namespace YachtDice.Shop case ModifierDefinition modifier: inventoryModel.AddModifier(modifier); break; - case DiceDefinitionSO dice: + case DiceDefinition dice: diceCollection.Add(dice); break; } diff --git a/Assets/Scripts/Tests/Editor/DiceCollectionTests.cs b/Assets/Scripts/Tests/Editor/DiceCollectionTests.cs index 4ac290f..790dd82 100644 --- a/Assets/Scripts/Tests/Editor/DiceCollectionTests.cs +++ b/Assets/Scripts/Tests/Editor/DiceCollectionTests.cs @@ -18,7 +18,7 @@ namespace YachtDice.Tests [Test] public void Add_IncreasesCount() { - var die = StandardDiceSO.CreateStandardD6ForTest(); + var die = StandardDice.CreateStandardD6ForTest(); collection.Add(die); @@ -28,7 +28,7 @@ namespace YachtDice.Tests [Test] public void Add_DuplicateId_Ignored() { - var die = StandardDiceSO.CreateStandardD6ForTest(); + var die = StandardDice.CreateStandardD6ForTest(); collection.Add(die); collection.Add(die); @@ -47,7 +47,7 @@ namespace YachtDice.Tests [Test] public void OwnsById_ReturnsTrueWhenOwned() { - var die = StandardDiceSO.CreateStandardD6ForTest(); + var die = StandardDice.CreateStandardD6ForTest(); collection.Add(die); @@ -63,7 +63,7 @@ namespace YachtDice.Tests [Test] public void Remove_DecreasesCount() { - var die = StandardDiceSO.CreateStandardD6ForTest(); + var die = StandardDice.CreateStandardD6ForTest(); collection.Add(die); collection.Remove(die); @@ -74,7 +74,7 @@ namespace YachtDice.Tests [Test] public void GetSaveData_ReturnsIds() { - var die = StandardDiceSO.CreateStandardD6ForTest(); + var die = StandardDice.CreateStandardD6ForTest(); collection.Add(die); @@ -86,8 +86,8 @@ namespace YachtDice.Tests [Test] public void LoadSaveData_RestoresDice() { - var die = StandardDiceSO.CreateStandardD6ForTest(); - var catalog = DiceCatalog.CreateForTest(new List { die }); + var die = StandardDice.CreateStandardD6ForTest(); + var catalog = DiceCatalog.CreateForTest(new List { die }); var ids = new List { "standard_d6" }; collection.LoadSaveData(ids, catalog); @@ -99,7 +99,7 @@ namespace YachtDice.Tests [Test] public void LoadSaveData_SkipsMissingIds() { - var catalog = DiceCatalog.CreateForTest(new List()); + var catalog = DiceCatalog.CreateForTest(new List()); var ids = new List { "nonexistent" }; collection.LoadSaveData(ids, catalog); @@ -110,7 +110,7 @@ namespace YachtDice.Tests [Test] public void Clear_RemovesAll() { - var die = StandardDiceSO.CreateStandardD6ForTest(); + var die = StandardDice.CreateStandardD6ForTest(); collection.Add(die); collection.Clear(); @@ -124,7 +124,7 @@ namespace YachtDice.Tests bool fired = false; collection.OnChanged += () => fired = true; - var die = StandardDiceSO.CreateStandardD6ForTest(); + var die = StandardDice.CreateStandardD6ForTest(); collection.Add(die); Assert.IsTrue(fired); diff --git a/Assets/Scripts/Tests/Editor/ScoringSystemTests.cs b/Assets/Scripts/Tests/Editor/ScoringSystemTests.cs index 49b2bd8..d44aff0 100644 --- a/Assets/Scripts/Tests/Editor/ScoringSystemTests.cs +++ b/Assets/Scripts/Tests/Editor/ScoringSystemTests.cs @@ -14,12 +14,12 @@ namespace YachtDice.Tests private CategoryDefinition twosCategory; private CategoryDefinition chanceCategory; private CategoryCatalog catalog; - private DiceDefinitionSO standardDice; + private DiceDefinition standardDice; [SetUp] public void SetUp() { - standardDice = DiceDefinitionSO.CreateForTest("d6", "d6"); + standardDice = DiceDefinition.CreateForTest("d6", "d6"); yachtCategory = NOfAKindCategory.CreateForTest("yacht", "Яхта", 5, fixedScoreMode: true, score: 50); onesCategory = SumOfValueCategory.CreateForTest("ones", "Единицы", 1); diff --git a/Assets/Scripts/Tests/Editor/ShopModelTests.cs b/Assets/Scripts/Tests/Editor/ShopModelTests.cs index b491824..5d12fbc 100644 --- a/Assets/Scripts/Tests/Editor/ShopModelTests.cs +++ b/Assets/Scripts/Tests/Editor/ShopModelTests.cs @@ -142,7 +142,7 @@ namespace YachtDice.Tests [Test] public void TryPurchase_DiceItem_AddsToDiceCollection() { - var die = DiceDefinitionSO.CreateForTest("test_die", shopPrice: 100); + var die = DiceDefinition.CreateForTest("test_die", shopPrice: 100); bool result = shop.TryPurchase(die); @@ -154,7 +154,7 @@ namespace YachtDice.Tests [Test] public void TryPurchase_DiceItem_CannotBeBoughtTwice() { - var die = DiceDefinitionSO.CreateForTest("unique_die", shopPrice: 100); + var die = DiceDefinition.CreateForTest("unique_die", shopPrice: 100); shop.TryPurchase(die); bool secondResult = shop.TryPurchase(die); @@ -167,7 +167,7 @@ namespace YachtDice.Tests [Test] public void GetItemState_Dice_Owned_AfterPurchase() { - var die = DiceDefinitionSO.CreateForTest("die1", shopPrice: 50); + var die = DiceDefinition.CreateForTest("die1", shopPrice: 50); shop.TryPurchase(die);