horooko/YachtDice
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Refactor] Replace [SerializeField] + getter with [field: SerializeField] auto-properties

Browse Source 
Convert serialized private fields with public arrow getters to
[field: SerializeField] auto-properties across ScriptableObjects
(DieDefinitionSO, CategoryDefinition, ModifierDefinition, Effect,
ModifierBehavior, SumOfValueCategory) and select MonoBehaviours
(DiceRoller, Dice.Entry struct). Fields with type-changing getters
(List→IReadOnlyList) or computed getters are intentionally kept as-is.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Konstantin Dyachenko
2026-03-01 21:28:48 +07:00
parent 30f9532fd7
commit f6c354d41c
8 changed files with 59 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Assets/Scripts/Modifiers/Definition/ModifierDefinition.cs
+22 -32
View File
@@ -8,36 +8,26 @@ namespace YachtDice.Modifiers.Definition
[CreateAssetMenu(fileName = "NewModifier", menuName = "YachtDice/Modifiers/Definition")]
public class ModifierDefinition : ScriptableObject, IShopItem
{
[Header("Identity")]
[SerializeField] private string id;
[SerializeField] private string displayName;
[SerializeField, TextArea] private string description;
[SerializeField] private Sprite icon;
[SerializeField] private ModifierRarity rarity;
[field: Header("Identity")]
[field: SerializeField] public string Id { get; private set; }
[field: SerializeField] public string DisplayName { get; private set; }
[field: SerializeField, TextArea] public string Description { get; private set; }
[field: SerializeField] public Sprite Icon { get; private set; }
[field: SerializeField] public ModifierRarity Rarity { get; private set; }
[Header("Economy")]
[SerializeField] private int shopPrice;
[SerializeField] private int sellPrice;
[field: Header("Economy")]
[field: SerializeField] public int ShopPrice { get; private set; }
[field: SerializeField] public int SellPrice { get; private set; }
[Header("Durability")]
[SerializeField] private bool hasLimitedUses;
[SerializeField] private int maxUses;
[SerializeField] private int maxStacks = 1;
[field: Header("Durability")]
[field: SerializeField] public bool HasLimitedUses { get; private set; }
[field: SerializeField] public int MaxUses { get; private set; }
[field: SerializeField] public int MaxStacks { get; private set; } = 1;
[Header("Behaviors")]
[SerializeField] private List<ModifierBehavior> behaviors = new();
public string Id => id;
public string DisplayName => displayName;
public string Description => description;
public Sprite Icon => icon;
public ModifierRarity Rarity => rarity;
public int ShopPrice => shopPrice;
public int SellPrice => sellPrice;
public bool HasLimitedUses => hasLimitedUses;
public int MaxUses => maxUses;
public int MaxStacks => maxStacks;
public bool IsRepurchasable => hasLimitedUses;
public bool IsRepurchasable => HasLimitedUses;
public IReadOnlyList<ModifierBehavior> Behaviors => behaviors;
#if UNITY_EDITOR
@@ -51,14 +41,14 @@ namespace YachtDice.Modifiers.Definition
ModifierRarity rarity = ModifierRarity.Common)
{
var so = CreateInstance<ModifierDefinition>();
so.id = id;
so.displayName = id;
so.description = id;
so.rarity = rarity;
so.shopPrice = shopPrice;
so.sellPrice = sellPrice;
so.hasLimitedUses = hasLimitedUses;
so.maxUses = maxUses;
so.Id = id;
so.DisplayName = id;
so.Description = id;
so.Rarity = rarity;
so.ShopPrice = shopPrice;
so.SellPrice = sellPrice;
so.HasLimitedUses = hasLimitedUses;
so.MaxUses = maxUses;
so.behaviors = behaviors ?? new List<ModifierBehavior>();
return so;
}