horooko/YachtDice
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Refactor] Replace [SerializeField] + getter with [field: SerializeField] auto-properties

Browse Source 
Convert serialized private fields with public arrow getters to
[field: SerializeField] auto-properties across ScriptableObjects
(DieDefinitionSO, CategoryDefinition, ModifierDefinition, Effect,
ModifierBehavior, SumOfValueCategory) and select MonoBehaviours
(DiceRoller, Dice.Entry struct). Fields with type-changing getters
(List→IReadOnlyList) or computed getters are intentionally kept as-is.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Konstantin Dyachenko
2026-03-01 21:28:48 +07:00
parent 30f9532fd7
commit f6c354d41c
8 changed files with 59 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Assets/Scripts/Modifiers/Definition/Effect.cs
+4 -7
View File
@@ -7,17 +7,14 @@ namespace YachtDice.Modifiers.Definition
{
public abstract class Effect : ScriptableObject, IEffect
{
[SerializeField] private ModifierPhase phase = ModifierPhase.Additive;
[SerializeField] private int priority;
public ModifierPhase Phase => phase;
public int Priority => priority;
[field: SerializeField] public ModifierPhase Phase { get; private set; } = ModifierPhase.Additive;
[field: SerializeField] public int Priority { get; private set; }
public abstract UniTask Apply(ModifierContext context, ModifierInstance instance);
#if UNITY_EDITOR
public void SetPhaseForTest(ModifierPhase p) => phase = p;
public void SetPriorityForTest(int p) => priority = p;
public void SetPhaseForTest(ModifierPhase p) => Phase = p;
public void SetPriorityForTest(int p) => Priority = p;
#endif
}
}